When I checkout common, run ant eclipse and then open eclipse I get this error:

The type com.sun.javadoc.RootDoc cannot be resolved. It is indirectly
referenced from required .class
files ExcludePrivateAnnotationsJDiffDoclet.java /common/src/java/org/apache/hadoop/classification/tools line
1 Java Problem

The problem is that the tools.jar is missing during build.

Now I'm extremely novice when it come to the ant build.xml but I think
I solved the problem by ensuring the tools.jar is added to the eclipse
project files (i.e. the .classpath file).
My question to you all: is this the correct solution? Is it worth
submitting as a patch?

diff --git build.xml build.xml
index 26ccfa0..168b34f 100644
--- build.xml
+++ build.xml
@@ -1571,6 +1571,7 @@
         <library pathref="ivy-test.classpath" exported="false" />
         <variable path="ANT_HOME/lib/ant.jar" exported="false" />
         <library path="${conf.dir}" exported="false" />
+        <library path="${java.home}/../lib/tools.jar" exported="false" />
       </classpath>
     </eclipse>
   </target>
--
Met vriendelijke groeten,

Niels Basjes

Hi Niels,

Yes, I have to do this same thing manually every time I re-run "ant eclipse".

So, it seems like we should add it to the eclipse target, like you
said. Feel free to file a JIRA and patch!

-Todd

On Wed, May 18, 2011 at 2:24 PM, Niels Basjes <[EMAIL PROTECTED]> wrote:
> When I checkout common, run ant eclipse and then open eclipse I get this error:
>
> The type com.sun.javadoc.RootDoc cannot be resolved. It is indirectly
> referenced from required .class
> files   ExcludePrivateAnnotationsJDiffDoclet.java       /common/src/java/org/apache/hadoop/classification/tools line
> 1       Java Problem
>
> The problem is that the tools.jar is missing during build.
>
> Now I'm extremely novice when it come to the ant build.xml but I think
> I solved the problem by ensuring the tools.jar is added to the eclipse
> project files (i.e. the .classpath file).
> My question to you all: is this the correct solution? Is it worth
> submitting as a patch?
>
> diff --git build.xml build.xml
> index 26ccfa0..168b34f 100644
> --- build.xml
> +++ build.xml
> @@ -1571,6 +1571,7 @@
>         <library pathref="ivy-test.classpath" exported="false" />
>         <variable path="ANT_HOME/lib/ant.jar" exported="false" />
>         <library path="${conf.dir}" exported="false" />
> +        <library path="${java.home}/../lib/tools.jar" exported="false" />
>       </classpath>
>     </eclipse>
>   </target>
>
>
>
>
> --
> Met vriendelijke groeten,
>
> Niels Basjes
>

--
Todd Lipcon
Software Engineer, Cloudera

Hi Todd,

2011/5/19 Todd Lipcon <[EMAIL PROTECTED]>:
> Yes, I have to do this same thing manually every time I re-run "ant eclipse".
>
> So, it seems like we should add it to the eclipse target, like you
> said. Feel free to file a JIRA and patch!

https://issues.apache.org/jira/browse/HADOOP-7305
(Hadoop QA should start in a few minutes to validate this).

--
Met vriendelijke groeten,

Niels Basjes

Committed. Thanks!

On Thu, May 19, 2011 at 5:14 AM, Niels Basjes <[EMAIL PROTECTED]> wrote:
> Hi Todd,
>
> 2011/5/19 Todd Lipcon <[EMAIL PROTECTED]>:
>> Yes, I have to do this same thing manually every time I re-run "ant eclipse".
>>
>> So, it seems like we should add it to the eclipse target, like you
>> said. Feel free to file a JIRA and patch!
>
> https://issues.apache.org/jira/browse/HADOOP-7305
> (Hadoop QA should start in a few minutes to validate this).
>
> --
> Met vriendelijke groeten,
>
> Niels Basjes
>

--
Todd Lipcon
Software Engineer, Cloudera