Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 14246: FLUME-2198. Avro Source must throw and disable itself if ipFilterRules contains invalid rules


Copy link to this message
-
Re: Review Request 14246: FLUME-2198. Avro Source must throw and disable itself if ipFilterRules contains invalid rules

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14246/#review26434
-----------------------------------------------------------
Looks good overall, just some minor feedback
flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51633>

    Unused import

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51626>

    This is a duplicate of line 416

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51627>

    Typo: should have. This appears multiple times in this test file.

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51628>

    

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51630>

    This should be outside the try/catch block, otherwise the finally close() will throw an NPE. Or, check for null in the finally block.

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51629>

    Nit: extra space

flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
<https://reviews.apache.org/r/14246/#comment51631>

    Nit: extra space
- Mike Percy
On Sept. 20, 2013, 7:03 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14246/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2013, 7:03 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2198
>     https://issues.apache.org/jira/browse/FLUME-2198
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Modified the way rules get configured. Modified tests to support this.
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java f6e4cfe
>   flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java e208fff
>
> Diff: https://reviews.apache.org/r/14246/diff/
>
>
> Testing
> -------
>
> All tests pass
>
>
> Thanks,
>
> Hari Shreedharan
>
>