Accumulo, mail # dev - TableLoadBalancer.getTableOperations get instance from HdfsZooInstance ... can it use configuration.getInstance() instead .. to promote unit testing?

TableLoadBalancer.getTableOperations get instance from HdfsZooInstance ... can it use configuration.getInstance() instead .. to promote unit testing?

David Medinets 2013-01-04, 02:52

In trunk, the abstract TabletBalancer class has a configuration class variable:

  protected ServerConfiguration configuration;

The TableLoadBalancer class has a getTableOperations method that get
an instance value from HdfsZooInstance:

  protected TableOperations getTableOperations() {
   if (tops == null)
   try {
   tops = HdfsZooInstance.getInstance().getConnector(SecurityConstants.getSystemCredentials()).tableOperations();
   } catch (AccumuloException e) {
   log.error("Unable to access table operations from within table
balancer", e);
   } catch (AccumuloSecurityException e) {
   log.error("Unable to access table operations from within table
balancer", e);
   }
   return tops;
  }

Is there any reason why the TableLoadBalancer can't use its
configuration variable to find the accumulo instance?

Re: TableLoadBalancer.getTableOperations get instance from HdfsZooInstance ... can it use configuration.getInstance() instead .. to promote unit testing?

John Vines 2013-01-04, 03:03

Ideally the balancer will have access to all the information it needs
because it's part of the Master, so it shouldn't be making any external
connections to get info.
On Thu, Jan 3, 2013 at 9:52 PM, David Medinets <[EMAIL PROTECTED]>wrote:

> In trunk, the abstract TabletBalancer class has a configuration class
> variable:
>
> protected ServerConfiguration configuration;
>
> The TableLoadBalancer class has a getTableOperations method that get
> an instance value from HdfsZooInstance:
>
> protected TableOperations getTableOperations() {
> if (tops == null)
> try {
> tops > HdfsZooInstance.getInstance().getConnector(SecurityConstants.getSystemCredentials()).tableOperations();
> } catch (AccumuloException e) {
> log.error("Unable to access table operations from within table
> balancer", e);
> } catch (AccumuloSecurityException e) {
> log.error("Unable to access table operations from within table
> balancer", e);
> }
> return tops;
> }
>
> Is there any reason why the TableLoadBalancer can't use its
> configuration variable to find the accumulo instance?
>