Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 16857: ACCUMULO-2182 - first set of backports to 1.4.5-SNAPSHOT


Copy link to this message
-
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to 1.4.5-SNAPSHOT
Bill Havanki 2014-01-15, 15:24


> On Jan. 14, 2014, 1:11 p.m., Josh Elser wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java, line 101
> > <https://reviews.apache.org/r/16857/diff/1/?file=422676#file422676line101>
> >
> >     The blind 1 second sleep still seems error prone to me, but, like Mike pointed out, it's just a backport of what's upstream.
>
> Bill Havanki wrote:
>     Before discovering ACCUMULO-1123, I had put in a sleep myself, but at least made the duration a XML configuration property for the node in the walk. Adding that configurability here (and in CreateUser) could be a new JIRA.
>    
>     In the end, I think the "right" answer is that there should be a password change call that only returns once the change is guaranteed to be in effect.
>
> Mike Drob wrote:
>     ACCUMULO-2200

Thanks Mike.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31740
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
>     https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>