Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request: New code for VectorizedRowBatch to form basis of vectorized query execution


Copy link to this message
-
Re: Review Request: New code for VectorizedRowBatch to form basis of vectorized query execution
Carl Steinbach 2013-04-17, 21:47

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10592/#review19350
-----------------------------------------------------------
Note: I did not flag every formatting issue individually.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java
<https://reviews.apache.org/r/10592/#comment40030>

    Formatting.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java
<https://reviews.apache.org/r/10592/#comment40040>

    Should these methods be abstract? If not, then I think you want to throw an UnsupportedOperationException("Not Implemented") instead of doing an assert or returning a string.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java
<https://reviews.apache.org/r/10592/#comment40031>

    Is there a reason these variables are public?

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java
<https://reviews.apache.org/r/10592/#comment40033>

    Public?

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java
<https://reviews.apache.org/r/10592/#comment40032>

    Formatting.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40034>

    Public?

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40035>

    Formatting: http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141999.html#342

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40041>

    Refer to the naming conventions for constants in the Java coding conventions.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40036>

    Use UnsupportedOperationException instead.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40037>

    Ditto

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40038>

    Formatting

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java
<https://reviews.apache.org/r/10592/#comment40039>

    Formatting.
- Carl Steinbach
On April 17, 2013, 8:50 p.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10592/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 8:50 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> New code for VectorizedRowBatch to form basis of vectorized query execution
>
>
> This addresses bug HIVE-4284.
>     https://issues.apache.org/jira/browse/HIVE-4284
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10592/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>