Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: Enhance NettyAvroRpcClient and the use of NettyServer to optionally use compression


Copy link to this message
-
Re: Review Request: Enhance NettyAvroRpcClient and the use of NettyServer to optionally use compression
Mike Percy 2013-02-22, 08:10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9427/#review16926
-----------------------------------------------------------

Ship it!
+1 looks good to me! Ran into some JUnit problem in IntelliJ but I plan on committing this as soon as I can check a couple things from an IDE tomorrow.

- Mike Percy
On Feb. 13, 2013, 5:02 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9427/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 5:02 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Enhance NettyAvroRpcClient and the use of NettyServer to optionally use compression
>
> Description: This JIRA will update AvroSource and NettyAvroRpcClient to optionally use ZlibEncoder and ZlibDecoder to compress communications between themselves.
>
> Patch Comment: Added compression options for both client and server.
> Note compress has be turn on both client and server for it to work.
> Client can have compression with out compression if compression level is set to 0
>
>
> This addresses bug FLUME-1915.
>     https://issues.apache.org/jira/browse/FLUME-1915
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java dc18c5d
>   flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java 4bf36e6
>   flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java cf9724c
>   flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java 1e642d8
>   flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 5042d11
>   flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 99ae010
>
> Diff: https://reviews.apache.org/r/9427/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Ted Malaska
>
>