Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Avro, mail # dev - Review Request 17549: AVRO-1443. Java builder and record API improvements.


Copy link to this message
-
Re: Review Request 17549: AVRO-1443. Java builder and record API improvements.
Christophe Taton 2014-02-03, 02:27

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17549/
-----------------------------------------------------------

(Updated Feb. 3, 2014, 2:27 a.m.)
Review request for Avro.
Changes
-------

Renamed the interface to Indexed/GenericRecordBuilderInterface.
Repository: avro
Description (updated)
-------

AVRO-1443. Java builder and record API improvements.

 - All builders (generic and specific) extend generic records
 - Specific record builders do NOT extend GenericRecordBuilder,
   but implement the generic record builders interfaces (Indexed/GenericRecordBuilderInterface).
 - Introduce interfaces for indexed/generic record builders.
 - Update velocity template to add the new methods required for builders.
 - Deleted FooBarSpecificRecord (apparently unused, no schema definition available).
Diffs (updated)
-----

  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/ErrorBuilder.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilder.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilderBase.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericContainer.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecord.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecordBuilder.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecordBuilderInterface.java PRE-CREATION
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/IndexedRecord.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/IndexedRecordBuilderInterface.java PRE-CREATION
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificErrorBuilderBase.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecord.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBase.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBuilderBase.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/test/java/org/apache/avro/FooBarSpecificRecord.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/test/java/org/apache/avro/compiler/TestSpecificCompiler.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/Player.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output/Player.java 1563756
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/java/org/apache/avro/tool/TestSpecificCompilerTool.java 1563756

Diff: https://reviews.apache.org/r/17549/diff/
Testing
-------

mvn clean test
Thanks,

Christophe Taton