Hi,

as of today, eclipse only shows 5 warnings about the zookeeper main codebase,
including tests. The remaining 5 should rather be solved by somebody knowing
the code better then me.
Would you like to make it a policy that new changes may not introduce new
warnings (at least not without a very good reason)?

There are however another 300+ warnings in contrib/loggraph.

I've filled these issues:
ZOOKEEPER-1245 fix compiler warnings in contrib loggraph
ZOOKEEPER-1244 resolve remaining compiler warnings

Regards,

Thomas Koch, http://www.koch.ro

Thanks Thomas.
Nice Work!

mahadev

On Tue, Oct 25, 2011 at 12:08 AM, Thomas Koch <[EMAIL PROTECTED]> wrote:
> Hi,
>
> as of today, eclipse only shows 5 warnings about the zookeeper main codebase,
> including tests. The remaining 5 should rather be solved by somebody knowing
> the code better then me.
> Would you like to make it a policy that new changes may not introduce new
> warnings (at least not without a very good reason)?
>
> There are however another 300+ warnings in contrib/loggraph.
>
> I've filled these issues:
> ZOOKEEPER-1245 fix compiler warnings in contrib loggraph
> ZOOKEEPER-1244 resolve remaining compiler warnings
>
> Regards,
>
> Thomas Koch, http://www.koch.ro
>

Super! Some comments inline below:

On Tue, Oct 25, 2011 at 12:08 AM, Thomas Koch <[EMAIL PROTECTED]> wrote:
> Would you like to make it a policy that new changes may not introduce new
> warnings (at least not without a very good reason)?

I'm all for this (similar to how we added findbugs as a commit gate
some years ago) -- here's the problem.

Unless you enforce this through some automatic process the warnings
will start creeping in again. Keep in mind not everyone uses eclipse.
Some might use intellij, some might just use a text editor, etc...
This would have to be applied consistently.

See the Hadoop QA bot checks (ala findbugs, RAT and the like). What
I'd suggest is that you add additional checks to build.xml (and then
we can add them to QA bot) for this. That way each patch will have
consistent constraints applied. What can we use to do this? Some
combination of checkstyle/PMD/???.

Patrick