Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1898. Thrift Source


Copy link to this message
-
Re: Review Request: FLUME-1898. Thrift Source
Brock Noland 2013-02-07, 15:23

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9352/#review16273
-----------------------------------------------------------
Hari, looks like a nice simple patch! A few comments below.
flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34728>

    If not specified this will throw an NPE. Could we have a better error message?

flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34727>

    Could we have a better error message here?

flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34725>

    If this ex is thrown, I assume serverTransport will be null. Will this be an issue?

flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34726>

    nit: spacing
- Brock Noland
On Feb. 7, 2013, 3:38 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9352/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2013, 3:38 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Thrift Source.
>
>
> This addresses bug FLUME-1898.
>     https://issues.apache.org/jira/browse/FLUME-1898
>
>
> Diffs
> -----
>
>   flume-ng-core/pom.xml 7db4f23
>   flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9352/diff/
>
>
> Testing
> -------
>
> Added several unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>