Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity of channels are positive.


+
Hari Shreedharan 2012-09-12, 21:40
+
Brock Noland 2012-12-06, 22:20
+
Hari Shreedharan 2012-12-10, 19:07
Copy link to this message
-
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity of channels are positive.
Brock Noland 2012-12-10, 23:55

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review14276
-----------------------------------------------------------

flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
<https://reviews.apache.org/r/7062/#comment30409>

    I think we should specify this is transaction capacity.

flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
<https://reviews.apache.org/r/7062/#comment30410>

    This isn't the checkpoint write time out as the message indicates, it's the checkpoint interval.
- Brock Noland
On Dec. 10, 2012, 7:07 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 7:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
>     https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 64a1350
>   flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
>   flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
>   flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Hari Shreedharan 2012-12-11, 00:00
+
Hari Shreedharan 2012-12-11, 19:29
+
Brock Noland 2012-12-11, 20:11
+
Hari Shreedharan 2012-09-25, 22:45
+
Hari Shreedharan 2012-09-30, 20:36