Sqoop, mail # dev - Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Jarek Cecho 2012-12-11, 17:18

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8530/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

We've been asking ResourceBundle object twice, so I've removed the second call.
This addresses bug SQOOP-759.
https://issues.apache.org/jira/browse/SQOOP-759
Diffs
-----

client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 6b632cb

Diff: https://reviews.apache.org/r/8530/diff/
Testing
-------

Tested on real cluster.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Venkat Ranganathan 2012-12-11, 19:31

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8530/#review14301
-----------------------------------------------------------
I tested on a single node client. Not sure if the diff I generated was wrong. Thanks for fixing it

- Venkat Ranganathan
On Dec. 11, 2012, 5:18 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8530/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 5:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> We've been asking ResourceBundle object twice, so I've removed the second call.
>
>
> This addresses bug SQOOP-759.
> https://issues.apache.org/jira/browse/SQOOP-759
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 6b632cb
>
> Diff: https://reviews.apache.org/r/8530/diff/
>
>
> Testing
> -------
>
> Tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Venkat Ranganathan 2012-12-12, 16:51

> On Dec. 11, 2012, 7:31 p.m., Venkat Ranganathan wrote:
> > I tested on a single node client. Not sure if the diff I generated was wrong. Thanks for fixing it

I went back to my environment. This exception is triggered if we have a .sqooprc file. I was not having it and hence I could not see it. Sorry about that
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8530/#review14301
-----------------------------------------------------------
On Dec. 11, 2012, 5:18 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8530/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 5:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> We've been asking ResourceBundle object twice, so I've removed the second call.
>
>
> This addresses bug SQOOP-759.
> https://issues.apache.org/jira/browse/SQOOP-759
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 6b632cb
>
> Diff: https://reviews.apache.org/r/8530/diff/
>
>
> Testing
> -------
>
> Tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Jarek Cecho 2012-12-12, 16:59

> On Dec. 11, 2012, 7:31 p.m., Venkat Ranganathan wrote:
> > I tested on a single node client. Not sure if the diff I generated was wrong. Thanks for fixing it
>
> Venkat Ranganathan wrote:
> I went back to my environment. This exception is triggered if we have a .sqooprc file. I was not having it and hence I could not see it. Sorry about that

Don't worry Venkat, it happens - we found the bug and we have a patch to solve it :-)
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8530/#review14301
-----------------------------------------------------------
On Dec. 11, 2012, 5:18 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8530/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 5:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> We've been asking ResourceBundle object twice, so I've removed the second call.
>
>
> This addresses bug SQOOP-759.
> https://issues.apache.org/jira/browse/SQOOP-759
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 6b632cb
>
> Diff: https://reviews.apache.org/r/8530/diff/
>
>
> Testing
> -------
>
> Tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

Re: Review Request: SQOOP-759 Sqoop2: Loading client resource file is failing on ResourceBundle not found exception

Cheolsoo Park 2012-12-12, 21:20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8530/#review14380
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Dec. 11, 2012, 5:18 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8530/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 5:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> We've been asking ResourceBundle object twice, so I've removed the second call.
>
>
> This addresses bug SQOOP-759.
> https://issues.apache.org/jira/browse/SQOOP-759
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 6b632cb
>
> Diff: https://reviews.apache.org/r/8530/diff/
>
>
> Testing
> -------
>
> Tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>