Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-826 Sqoop2: Add log4j test configuration to all maven modules


+
Jarek Cecho 2013-01-10, 14:03
Copy link to this message
-
Re: Review Request: SQOOP-826 Sqoop2: Add log4j test configuration to all maven modules
Jarek Cecho 2013-01-10, 14:05

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8922/
-----------------------------------------------------------

(Updated Jan. 10, 2013, 2:05 p.m.)
Review request for Sqoop.
Changes
-------

I've added steps that can be used for verifying my patch.
Description
-------

I've added the same configuration file to every maven module that have type "jar" or "war" (e.g. not to "dummy" modules of type "pom"). Please note that the "debug" setting should be fine as this file should be loaded only during tests.
This addresses bug SQOOP-826.
    https://issues.apache.org/jira/browse/SQOOP-826
Diffs
-----

  client/src/test/resources/log4j.properties PRE-CREATION
  common/src/test/resources/log4j.properties PRE-CREATION
  connector/connector-generic-jdbc/src/test/resources/log4j.properties PRE-CREATION
  core/src/test/resources/log4j.properties PRE-CREATION
  repository/repository-derby/src/test/resources/log4j.properties PRE-CREATION
  server/src/test/resources/log4j.properties PRE-CREATION
  spi/src/test/resources/log4j.properties PRE-CREATION
  submission/mapreduce/src/test/resources/log4j.properties PRE-CREATION

Diff: https://reviews.apache.org/r/8922/diff/
Testing (updated)
-------

I've run tests and I can no longer see the log4j warnings of missing configuration file.

Steps that I've used to verify this patch:

1) Run mvn clean test

2) grep "Please initialize the log4j system properly" * -r | wc -l

3) Apply my patch

4) Rerun steps 1 and 2, output should be "0"
Thanks,

Jarek Cecho

+
Cheolsoo Park 2013-01-23, 00:39