Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request: PIG-2978 TestLoadStoreFuncLifeCycle fails with hadoop-2.0.x


Copy link to this message
-
Re: Review Request: PIG-2978 TestLoadStoreFuncLifeCycle fails with hadoop-2.0.x
Rohini Palaniswamy 2012-11-20, 00:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8121/#review13603
-----------------------------------------------------------

Ship it!

test/org/apache/pig/TestLoadStoreFuncLifeCycle.java
<https://reviews.apache.org/r/8121/#comment29179>

    Could have logged the job's id instead of the class name but it does not matter to the test case anyways. So no problem.

test/org/apache/pig/TestLoadStoreFuncLifeCycle.java
<https://reviews.apache.org/r/8121/#comment29178>

    Checked that the additional call is fine. LocalJobRunner gets the outputcommitter to call setupJob (MAPREDUCE-3563) which was not done in H20's LocalJobRunner.
- Rohini Palaniswamy
On Nov. 19, 2012, 5:28 a.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8121/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 5:28 a.m.)
>
>
> Review request for pig and Santhosh Srinivasan.
>
>
> Description
> -------
>
> Please see:
> https://issues.apache.org/jira/browse/PIG-2978
>
>
> This addresses bug PIG-2978.
>     https://issues.apache.org/jira/browse/PIG-2978
>
>
> Diffs
> -----
>
>   test/org/apache/pig/TestLoadStoreFuncLifeCycle.java 9e453af
>
> Diff: https://reviews.apache.org/r/8121/diff/
>
>
> Testing
> -------
>
> ant clean test -Dhadoopversion=20/23
>
>
> Thanks,
>
> Cheolsoo Park
>
>