-
Re: Review Request: SQOOP-467 Add support for Oracle BINARY_FLOAT and BINARY_DOUBLE data typesCheolsoo Park 2012-06-01, 00:25
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4641/
-----------------------------------------------------------
(Updated 2012-06-01 00:25:16.610030)
Review request for Sqoop, Bilung Lee and Jarek Cecho.
Changes
-------
Rebased the patch.
Summary (updated)
-------
Sqoop import does not support BINARY_FLOAT and BINARY_DOUBLE for Oracle db.
The changes include:
1) Add 3 methods to SqlManager class: toDbSpecificJavaType(), toDbSpecificHiveType(), and toDbSpecificAvroType().
2) Override these methods in OracleManager to identify Oracle-specific types based on their type name strings.
3) Eliminate uses of reflection from OracleManager.
4) Factor out special handling for "YEAR" in MySQLManager into a separate method: overrideSqlType().
5) Add unit tests to OracleCompatTest for BINARY_FLOAT and BINARY_DOUBLE.
Note that Hive/Avro support for BINARY_FLOAT and BINARY_DOUBLE is not added here. It will be implemented in the future.
This addresses bug SQOOP-467.
https://issues.apache.org/jira/browse/SQOOP-467
Diffs (updated)
-----
/src/java/org/apache/sqoop/manager/MySQLManager.java 1344922
/src/java/org/apache/sqoop/manager/OracleManager.java 1344922
/src/java/org/apache/sqoop/manager/SqlManager.java 1344922
/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1344922
Diff: https://reviews.apache.org/r/4641/diff
Testing
-------
1) Verified with Oracle XE 10g that new tests pass.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.
Thanks,
Cheolsoo
