Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1975. Use TThreadedSelectServer in ThriftSource if it is available


+
Hari Shreedharan 2013-04-09, 07:09
Copy link to this message
-
Re: Review Request: FLUME-1975. Use TThreadedSelectServer in ThriftSource if it is available

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10364/#review22292
-----------------------------------------------------------

Ship it!
+1, change looks good, tests pass using both profiles

- Mike Percy
On April 9, 2013, 7:09 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10364/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 7:09 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Use reflection to figure out which server to use.
>
>
> This addresses bug FLUME-1975.
>     https://issues.apache.org/jira/browse/FLUME-1975
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java 5856e90
>   pom.xml 9aff211
>
> Diff: https://reviews.apache.org/r/10364/diff/
>
>
> Testing
> -------
>
> Ran unit tests in both hadoop-1 and hadoop-2 profiles. Use the test logs to verify that TThreadPoolServer is used in Hadoop-1 profile, but no log in Hadoop-2 profile.
>
>
> Thanks,
>
> Hari Shreedharan
>
>