Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem


Copy link to this message
-
Re: Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15279/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 2:09 p.m.)
Review request for accumulo.
Changes
-------

- Location now shown as filesystem URI + directory.
- Added suggestion to change instance.dfs.dir.
Bugs: ACCUMULO-1556
    https://issues.apache.org/jira/browse/ACCUMULO-1556
Repository: accumulo
Description
-------

The Initialize class now generates clearer error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used.

Note that to facilitate unit testing, the verification logic in Initialize.doInit() was refactored into a checkInit() method.
Diffs (updated)
-----

  pom.xml 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8
  src/server/pom.xml 6421bc69cda5116f9716d30adc3d510baa3bb7d6
  src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc
  src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/15279/diff/
Testing
-------

Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested successful initialization and correct emission of error messages when instance.dfs.uri was used and was not used. Also, implemented unit tests for altered code.
Thanks,

Bill Havanki