Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: Ability to specify the capacity of MemoryChannel in bytes


Copy link to this message
-
Re: Review Request: Ability to specify the capacity of MemoryChannel in bytes


> On Oct. 4, 2012, 7:16 p.m., Hari Shreedharan wrote:
> > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java, line 283
> > <https://reviews.apache.org/r/6982/diff/5/?file=174287#file174287line283>
> >
> >     This should be done only if the resize actually happens right? The one case where the resize fails because of the situation in line 265 should keep the lastByteCapacity same as before.

agree
- Ted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6982/#review12177
-----------------------------------------------------------
On Oct. 4, 2012, 11:47 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6982/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 11:47 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> 1. The user will be able to define a byteCapacity and a byteCapacityBufferPercentage.
> 2. Events byte size will be estimated from there body contents
> 3. On put bytes are added to current total
> 4. On commit any uncommitted takes are removed from the current byte total
> 5. On rollover any uncommitted puts are removed from the current byte total
>
>
> This addresses bug FLUME-1535.
>     https://issues.apache.org/jira/browse/FLUME-1535
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
>   flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
>
> Diff: https://reviews.apache.org/r/6982/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ted Malaska
>
>