Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect


Copy link to this message
-
Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect


> On April 27, 2013, 6:59 a.m., Carl Steinbach wrote:
> > common/src/scripts/saveVersion.sh, line 66
> > <https://reviews.apache.org/r/10812/diff/1/?file=285221#file285221line66>
> >
> >     I think the output directory was correct to begin with. Please revert.
>
> Thejas Nair wrote:
>     HiveVersionInfo is in org/apache/hive/common/util/, so this package-info.java with the annotations expected by HiveVersionInfo needs to be in same package. Otherwise  HiveVersionInfo will not work.
>     Hence the change to move it to this dir. Please let me know if you disagree.
>

Reverting the package-info.java location change. Old location works.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10812/#review19822
-----------------------------------------------------------
On April 28, 2013, 12:22 a.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10812/
> -----------------------------------------------------------
>
> (Updated April 28, 2013, 12:22 a.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> HIVE-4373
>
>
> This addresses bug HIVE-4373.
>     https://issues.apache.org/jira/browse/HIVE-4373
>
>
> Diffs
> -----
>
>   common/build.xml 731f26e
>   jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 3d1a969
>   jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 938dd9a
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 18594cb
>
> Diff: https://reviews.apache.org/r/10812/diff/
>
>
> Testing
> -------
>
> Unit test included. Also tested with remote HS2 server.
>
>
> Thanks,
>
> Thejas Nair
>
>