Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill >> mail # dev >> Review Request 13029: Implement IsNull and IsNotNull DrillFunctions


Copy link to this message
-
Review Request 13029: Implement IsNull and IsNotNull DrillFunctions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13029/
-----------------------------------------------------------

Review request for drill.
Repository: drill-git
Description
-------

Implements IsNull and IsNotNull DrillFunctions with simple tests.

Also fixes a few tangential bugs.  To view in Github, see https://github.com/vrtx/incubator-drill/commits/NullOp.
Diffs
-----

  sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java 0bec184
  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java dfec62e
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 664940d
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNotNull.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/IsNull.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/Float8Holder.java 78e7cb8
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/holders/NullableFloat8Holder.java f8fa224
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MockRecordReader.java 687b28b
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 0f5b7d0
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java PRE-CREATION
  sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNotNull.json PRE-CREATION
  sandbox/prototype/exec/java-exec/src/test/resources/functions/testIsNull.json PRE-CREATION

Diff: https://reviews.apache.org/r/13029/diff/
Testing
-------
Thanks,

Ben Becker

+
Timothy Chen 2013-07-30, 01:04
+
Jacques Nadeau 2013-07-30, 01:02