Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Accumulo, mail # dev - Review Request: Accumulo proxy source 11/13/12


+
Chris McCubbin 2012-11-13, 16:37
Copy link to this message
-
Re: Review Request: Accumulo proxy source 11/13/12
keith@... 2012-11-13, 20:57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8039/#review13399
-----------------------------------------------------------

/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/8039/#comment28732>

    seems confusing to accept a range of keys and then only use the row portion of the range...  eithier use the entire key or compose PRange out of rows...

/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/8039/#comment28733>

    numRead does not seem to be incremented...
    
    If numRead were incremented, I think its possible that (numRead == k) could be true when there is no more data... maybe do ret.setMore(batchScanner.hasNext())

/trunk/proxy/src/main/thrift/proxy.thrift
<https://reviews.apache.org/r/8039/#comment28728>

    How does the user indicate that they would like the system to set the timestamp?

/trunk/proxy/src/main/thrift/proxy.thrift
<https://reviews.apache.org/r/8039/#comment28730>

    I would advocate adding the following and making mutation use these
    
    struct PCoumnUpdate {
       1:binary cf,
       2: binary cq,
       3:binary cv,
       4:i64 ts
       5:bool useSystemTime
       6:binary value
    }
    
    struct PColumnDelete {
       1:binary cf,
       2: binary cq,
       3:binary cv,
       4:i64 ts
       5:bool useSystemTime
    }

/trunk/proxy/src/main/thrift/proxy.thrift
<https://reviews.apache.org/r/8039/#comment28731>

    need a method to create a normal scanner in addition to the method to create a batch scanner

/trunk/proxy/src/main/thrift/proxy.thrift
<https://reviews.apache.org/r/8039/#comment28729>

    should take a list of ranges
- kturner
On Nov. 13, 2012, 4:37 p.m., Chris McCubbin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8039/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2012, 4:37 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> Patch submitted by Chris McCubbin to add thrift proxy to Accumulo, second version
>
>
> Diffs
> -----
>
>   /trunk/pom.xml 1408812
>   /trunk/proxy/README PRE-CREATION
>   /trunk/proxy/examples/python/README PRE-CREATION
>   /trunk/proxy/examples/python/TestClient.py PRE-CREATION
>   /trunk/proxy/examples/python/data/__init__.py PRE-CREATION
>   /trunk/proxy/examples/python/data/constants.py PRE-CREATION
>   /trunk/proxy/examples/python/data/ttypes.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION
>   /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION
>   /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION
>   /trunk/proxy/examples/ruby/README PRE-CREATION
>   /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/data_constants.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/data_types.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION
>   /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION
>   /trunk/proxy/pom.xml PRE-CREATION
>   /trunk/proxy/proxy.properties PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java PRE-CREATION
+
Chris McCubbin 2012-11-13, 21:30
+
Chris McCubbin 2012-11-13, 21:34
+
Chris McCubbin 2012-11-13, 21:56
+
Chris McCubbin 2012-11-14, 18:51
+
keith@... 2012-11-14, 19:28
+
Adam Fuchs 2012-11-14, 20:22
+
keith@... 2012-11-14, 20:30
+
Chris McCubbin 2012-11-14, 20:31
+
keith@... 2012-11-14, 20:34
+
Billie Rinaldi 2012-11-15, 17:40
+
Keith Turner 2012-11-15, 18:00
+
Chris McCubbin 2012-11-16, 16:14