Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Review Request: PIG-3141 [piggybank] Giving CSVExcelStorage an option to handle header rows


+
Jonathan Packer 2013-03-01, 14:51
+
Jonathan Packer 2013-03-01, 14:52
+
Cheolsoo Park 2013-03-20, 19:05
+
Cheolsoo Park 2013-03-20, 21:04
Copy link to this message
-
Re: Review Request: PIG-3141 [piggybank] Giving CSVExcelStorage an option to handle header rows
Jonathan Packer 2013-03-25, 15:17

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9697/
-----------------------------------------------------------

(Updated March 25, 2013, 3:17 p.m.)
Review request for pig.
Changes
-------

Code review changes for Cheolsoo
Description
-------

Reviewboard for https://issues.apache.org/jira/browse/PIG-3141

Adds a "header treatment" option to CSVExcelStorage allowing header rows (first row with column names) in files to be skipped when loading, or for a header row with column names to be written when storing. Should be backwards compatible--all unit-tests from the old CSVExcelStorage pass.
Diffs (updated)
-----

  contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java 568b3f3
  contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestCSVExcelStorage.java 9bed527

Diff: https://reviews.apache.org/r/9697/diff/
Testing
-------

cd contrib/piggybank/java
ant -Dtestcase=TestCSVExcelStorage test
Thanks,

Jonathan Packer

+
Cheolsoo Park 2013-03-26, 04:13