Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 15151: Better error reporting by async threads in HiveServer2


Copy link to this message
-
Re: Review Request 15151: Better error reporting by async threads in HiveServer2
Thejas Nair 2013-11-07, 03:33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15151/#review28348
-----------------------------------------------------------

service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java
<https://reviews.apache.org/r/15151/#comment55179>

    Ok, I see that this keeps the behavior same as before. Can you please add a comment saying why its null ? It is not very obvious.
    

service/src/test/org/apache/hive/service/cli/CLIServiceTest.java
<https://reviews.apache.org/r/15151/#comment55180>

    The error messages should not change without a good reason. Users might be relying on it. It can change, but then tests that use it would also need to change.
    
    Checking for error message here will ensure that error is getting propagated properly.
    
- Thejas Nair
On Nov. 1, 2013, 12:54 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15151/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:54 a.m.)
>
>
> Review request for hive, Prasad Mujumdar and Thejas Nair.
>
>
> Bugs: HIVE-5230
>     https://issues.apache.org/jira/browse/HIVE-5230
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> [HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object).
>
>
> Diffs
> -----
>
>   service/src/java/org/apache/hive/service/cli/CLIService.java 1a7f338
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874
>   service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java d6caed1
>   service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d
>
> Diff: https://reviews.apache.org/r/15151/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>