Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-604 Easy throttling feature for MySQL exports


+
Zoltán Tóth-Czifra 2012-09-27, 15:47
+
Zoltán Tóth-Czifra 2012-10-01, 09:54
+
Abhijeet Gaikwad 2012-10-01, 11:13
+
Zoltán Tóth-Czifra 2012-10-02, 10:08
+
Abhijeet Gaikwad 2012-10-02, 15:45
+
Abhijeet Gaikwad 2012-10-03, 14:25
+
Zoltán Tóth-Czifra 2012-10-02, 16:08
+
Zoltán Tóth-Czifra 2012-10-04, 12:25
Copy link to this message
-
Re: Review Request: SQOOP-604 Easy throttling feature for MySQL exports

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7135/#review12934
-----------------------------------------------------------
My aplogies for replying late on this, had been a lot busy.

I think we will have to do a round more :). I see 5 checkstyle errors, out of which please resolve the 3 (in file MySQLExportMapper.java) which are due to the changes you made in the code. I will raise a JIRA for other two which are not a part of your change.

How to 'checkstyle' steps:
1. run 'ant checkstyle'
2. Now above command may be successful, but it generates an HTML file(checkstyle-errors.html to be exact) in 'build' dir under $SQOOP_HOME. Opening that file gives the details of the checkstyle errrors.

Thanks.

- Abhijeet Gaikwad
On Oct. 4, 2012, 12:25 p.m., Zoltán Tóth-Czifra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7135/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 12:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Code review for SQOOP-604, see https://issues.apache.org/jira/browse/SQOOP-604
>
> The solution in short: Using the already existing "checkpoint" feature of the direct (--direct) MySQL exports (the export process is restarted every X bytes written), extending it with a new config value that would simply make the thread sleep for X milliseconds at the checkbpoints. With low enough byte count limit this can be a simple yet powerful throttling mechanism.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java a4e8b88
>
> Diff: https://reviews.apache.org/r/7135/diff/
>
>
> Testing
> -------
>
> Executing with different settings of sqoop.mysql.export.checkpoint.bytes and sqoop.mysql.export.sleep.ms:
>
> 33554432B / 0ms: Transferred 4.7579 MB in 8.7175 seconds (558.8826 KB/sec)
> 102400B / 500ms: Transferred 4.7579 MB in 35.7794 seconds (136.1698 KB/sec)
> 51200B / 500ms: Transferred 4.758 MB in 57.8675 seconds (84.1959 KB/sec)
> 51200B / 250ms: Transferred 4.7579 MB in 35.0293 seconds (139.0854 KB/sec)
>
> I did not add unit tests yet and as it involves calling to Thread.sleep, I find testing this difficult. Unfortunately there is no "machine" or "environment" object that could be injected to these classes as mocks that could take care of time-related fixtures.
>
>
> Thanks,
>
> Zoltán Tóth-Czifra
>
>

+
Zoltán Tóth-Czifra 2012-11-02, 12:32
+
Abhijeet Gaikwad 2012-11-03, 05:18
+
Zoltán Tóth-Czifra 2012-11-03, 10:35
+
Abhijeet Gaikwad 2012-09-28, 09:59
+
Zoltán Tóth-Czifra 2012-09-28, 10:27
+
Abhijeet Gaikwad 2012-09-28, 11:45