Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 13722: SQOOP-1180 Sqoop2: Metadata upgrade is calling validators with Model classes instead of configuration objects


Copy link to this message
-
Review Request 13722: SQOOP-1180 Sqoop2: Metadata upgrade is calling validators with Model classes instead of configuration objects
Jarek Cecho 2013-08-22, 02:48

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13722/
-----------------------------------------------------------

Review request for Sqoop.
Bugs: SQOOP-1180
    https://issues.apache.org/jira/browse/SQOOP-1180
Repository: sqoop-sqoop2
Description
-------

I've fixed the calls to create the configuration objects and convert the model classes prior calling the validator.
Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/Repository.java 7c7673f7df76110e287ca0fbc8093f1f880b8cb5
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 40a6ecad351682cf6a582dfa46f31b156195949a

Diff: https://reviews.apache.org/r/13722/diff/
Testing
-------

I've fixed the unit tests and verified the upgrade on real cluster.
Thanks,

Jarek Cecho