Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive >> mail # dev >> Review Request: HIVE-4535 - hive build fails with hadoop 0.20


+
Thejas Nair 2013-05-10, 07:07
+
Carl Steinbach 2013-05-10, 07:34
Copy link to this message
-
Re: Review Request: HIVE-4535 - hive build fails with hadoop 0.20


> On May 10, 2013, 7:34 a.m., Carl Steinbach wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, line 385
> > <https://reviews.apache.org/r/11036/diff/1/?file=289930#file289930line385>
> >
> >     Hive depends on commons-lang v2.4 which supports join(Collection, String) and join(Collection, char). I don't think there's a need to call toArray().

thanks for pointing it out, looks like i didn't scroll down far enough when i looked at the doc!
> On May 10, 2013, 7:34 a.m., Carl Steinbach wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, line 963
> > <https://reviews.apache.org/r/11036/diff/1/?file=289930#file289930line963>
> >
> >     We can avoid the oah.util.StringUtils dependency entirely by doing this:
> >    
> >     LOG.error("Converting exception to MetaException", e);

agreed, this pattern seems unnecessary in most places.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11036/#review20415
-----------------------------------------------------------
On May 10, 2013, 4:40 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11036/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 4:40 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> ant package -Dhadoop.mr.rev=20
> leads to -
>     [javac] /Users/thejas/hive_thejas_git/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java:382: cannot find symbol
>     [javac] symbol  : method join(java.lang.String,java.util.List<java.lang.String>)
>     [javac] location: class org.apache.hadoop.util.StringUtils
>     [javac]           StringUtils.join(",", incompatibleCols)
>
> import has hadoop StringUtils , but it does not have this function in hadoop 0.20 libraries.
>
>
> This addresses bug HIVE-4535.
>     https://issues.apache.org/jira/browse/HIVE-4535
>
>
> Diffs
> -----
>
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f9da781
>
> Diff: https://reviews.apache.org/r/11036/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thejas Nair
>
>

+
Thejas Nair 2013-05-10, 16:40