Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF


Copy link to this message
-
Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF
Carl Steinbach 2013-12-17, 21:59

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15654/#review30574
-----------------------------------------------------------

ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFLTrim.java
<https://reviews.apache.org/r/15654/#comment58540>

    For these new tests please change the package to org.apache.hive.ql.udf.generic and move them to the directory src/test/org/apache/hadoop/hive/ql/udf/generic.
- Carl Steinbach
On Dec. 17, 2013, midnight, Mohammad Islam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15654/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, midnight)
>
>
> Review request for hive, Ashutosh Chauhan, Carl Steinbach, and Jitendra Pandey.
>
>
> Bugs: HIVE-5829
>     https://issues.apache.org/jira/browse/HIVE-5829
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Rewrite the UDFS *pads and *trim using GenericUDF.
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a895d65
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java bca1f26
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLTrim.java dc00cf9
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLpad.java d1da19a
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRTrim.java 2bcc5fa
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRpad.java 9652ce2
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTrim.java 490886d
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLTrim.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRTrim.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrim.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java eff251f
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFLTrim.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFLpad.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFRTrim.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFRpad.java PRE-CREATION
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFTrim.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15654/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mohammad Islam
>
>