Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Re: Review Request: Changes for PIG-3321


Copy link to this message
-
Re: Review Request: Changes for PIG-3321
Harvey Chong 2013-05-14, 22:18

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11155/
-----------------------------------------------------------

(Updated May 14, 2013, 10:18 p.m.)
Review request for pig and Rohini Palaniswamy.
Description
-------

Changes for https://issues.apache.org/jira/browse/PIG-3321

Overview:
AvroStorage.java - If 'schema' argument is passed to constructor, use it as the reader schema on load.  Moved getSchema() to AvroStorageUtils and made public+static, so it can be called from PigAvroRecordReader.
AvroStorageUtils.java - Moved getSchema() here.
PigAvroInputFormat.java - nothing functional here, just renamed 'schema' to 'readerSchema' for clarity.
PigAvroRecordReader.java - The constructor now determines the writer schema for its split, and passes both reader and writer schema to the PigAvroDatumReader constructor, which will allow the Avro code to resolve the two.
PigAvroDatumReader.java - Changed readRecord() to add entries to the output Tuple in writer order rather than reader order.
TestAvroStorage.java - Added a new testcase for user specified schema in load.
Diffs
-----

  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1482017
  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1482017
  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroDatumReader.java 1482017
  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1482017
  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1482017
  http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1482017

Diff: https://reviews.apache.org/r/11155/diff/
Testing
-------
Thanks,

Harvey Chong

+
Rohini Palaniswamy 2013-05-14, 23:45
+
Harvey Chong 2013-05-15, 15:44
+
Rohini Palaniswamy 2013-05-15, 17:04
+
Harvey Chong 2013-05-15, 19:01
+
Rohini Palaniswamy 2013-05-15, 19:29