Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package


Copy link to this message
-
Re: Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package


> On Aug. 6, 2013, 11:19 p.m., Hari Shreedharan wrote:
> > This looks good, though I'd like to revisit some of the error code separation between the client module and the shell module. I think some of those in Shell needs to move to client and also that any duplicates should be removed. Could you please file a follow up jira to discuss this?

Yes, there do have several duplicate error codes which are used by both of these 2 modules. Will definitely fix this by a follow up jira.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13338/#review24760
-----------------------------------------------------------
On Aug. 6, 2013, 8 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13338/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 8 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-921
>     https://issues.apache.org/jira/browse/SQOOP-921
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 0ba78c6da15ad3a67bdec754025066abc4792eea
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Tue Aug 6 11:24:08 2013 -0700
>
>     SQOOP-921: Sqoop2: Create standalone shell package
>
> :100644 100644 c6351ed... 975773d... M client/pom.xml
> :000000 100644 0000000... aafb5b0... A client/src/main/java/org/apache/sqoop/client/ClientError.java
> :100644 100644 158e46c... f9e7ddd... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 000000 d96f44e... 0000000... D client/src/main/java/org/apache/sqoop/client/core/ClientError.java
> :100644 000000 999790d... 0000000... D client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 befb793... d9229f5... M client/src/main/java/org/apache/sqoop/client/request/Request.java
> :100644 000000 283b025... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java
> :100644 000000 0538901... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
> :100644 000000 6f62813... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
> :100644 000000 ac555e1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java
> :100644 000000 04b240c... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
> :100644 000000 cc4d546... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
> :100644 000000 6a5b3a1... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java
> :100644 000000 18d3a70... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
> :100644 000000 736be20... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
> :100644 000000 5cbd6db... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java
> :100644 000000 e04292a... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
> :100644 000000 5962cd2... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
> :100644 000000 8a2c1c7... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java
> :100644 000000 ed6dc3c... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
> :100644 000000 9e4e320... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java
> :100644 000000 c6f831d... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java
> :100644 000000 c831123... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java