Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-505 Trailing space after jar in managers.d/connectors causes file not found


Copy link to this message
-
Re: Review Request: SQOOP-505 Trailing space after jar in managers.d/connectors causes file not found

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5432/#review8435
-----------------------------------------------------------

Ship it!
Thanks for the fix.  +1.

- Bilung Lee
On June 20, 2012, 9:58 p.m., Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5432/
> -----------------------------------------------------------
>
> (Updated June 20, 2012, 9:58 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Bilung Lee.
>
>
> Description
> -------
>
> Whitespace should be trimmed when the property file is loaded.
>
>
> This addresses bug SQOOP-505.
>     https://issues.apache.org/jira/browse/SQOOP-505
>
>
> Diffs
> -----
>
>   /src/java/org/apache/sqoop/ConnFactory.java 1351937
>
> Diff: https://reviews.apache.org/r/5432/diff/
>
>
> Testing
> -------
>
> 1) ant test, ant test -Dthirdparty=true, and ant checkstyle.
>
> 2) Tested using Teradata connector with the following 'connector' file:
>
> <some space>com.cloudera.sqoop.manager.TeradataManagerFactory<some space>=<some space>/home/cheolsoo/workspace/sqoop_505/sqoop-td-connector-1.0.5/sqoop-td-connector-1.0.5.jar<some space>
>
>
> Thanks,
>
> Cheolsoo Park
>
>