Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 14454: FLUME-2202. AsyncHBaseSink should coalesce increments to reduce RPC roundtrips


Copy link to this message
-
Re: Review Request 14454: FLUME-2202. AsyncHBaseSink should coalesce increments to reduce RPC roundtrips
Mike Percy 2013-10-03, 06:34

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14454/#review26641
-----------------------------------------------------------

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51904>

    @VisibleForTesting ?

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51903>

    Style: Would be nice to name this var consistently with the other two.

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51892>

    Style: Seems like the spacing here is inconsistent with the rest of the file, which leaves a space after "if" and before the brace.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/IncrementAsyncHBaseSerializer.java
<https://reviews.apache.org/r/14454/#comment51891>

    Would be nice to add a comment at the top of this class with something like: AsyncHBaseEventSerializer implementation that increments a counter on a row key equal to the event body bytes.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51900>

    I wonder if this could be broken into 2 or 3 functions in order to be easier to follow. If not easy to do that it's not a big deal.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51896>

    Nit: Would be better to use org.apache.flume.sink.hbase.IncrementAsyncHBaseSerializer.class.getName() so that this is refactorable and shadable.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51897>

    Nit: Same with this.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51898>

    I'm confused why we are using the same Context object to configure both a Sink and a Channel. Probably a minor bug.

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51895>

    Style: conditional spacing

flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
<https://reviews.apache.org/r/14454/#comment51902>

    Style: missing a space
Looks good overall, but needs user docs. Other than that I just found a bunch of nits.

- Mike Percy
On Oct. 3, 2013, 5:32 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14454/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 5:32 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2202
>     https://issues.apache.org/jira/browse/FLUME-2202
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Added a new config to coalesce increments.
>
>
> Diffs
> -----
>
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 5a59b56
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 5e297b1
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 7fdc75b
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/IncrementAsyncHBaseSerializer.java PRE-CREATION
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java a0c04eb
>
> Diff: https://reviews.apache.org/r/14454/diff/
>
>
> Testing
> -------
>
> All current tests pass. Added 2 new tests