HBase, mail # dev - Re: need a little help with a patch submission

need a little help with a patch submission

Sujee Maniyam 2012-03-12, 19:39

https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635

I don't quite understand why the patching failed.

I am relatively a newbie and following this :
http://hbase.apache.org/book/submitting.patches.html

Help appreciated.

thanks very much
Sujee
----output from :
https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console

patching file b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
Hunk #1 FAILED at 466.
1 out of 1 hunk FAILED -- saving rejects to file
b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
PATCH APPLICATION FAILED
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvaluation_HBASE_5198.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

-1 patch. The patch command could not apply the patch.

Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console

This message is automatically generated.
-------

http://sujee.net

Re: need a little help with a patch submission

Shrijeet Paliwal 2012-03-12, 19:43

Sujee,
Try "git diff --no-prefix"

-Shrijeet
On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:
>
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
>
> I don't quite understand why the patching failed.
>
> I am relatively a newbie and following this :
> http://hbase.apache.org/book/submitting.patches.html
>
> Help appreciated.
>
> thanks very much
> Sujee
>
>
> ----output from :
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> patching file b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
> Hunk #1 FAILED at 466.
> 1 out of 1 hunk FAILED -- saving rejects to file
> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
> PATCH APPLICATION FAILED
>
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvaluation_HBASE_5198.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output:
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> This message is automatically generated.
> -------
>
> http://sujee.net

Re: need a little help with a patch submission

Gregory Chanan 2012-03-12, 19:43

Sujee,

I think you need to create the patch with the --no-prefix option in git.

Greg

On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:

>
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
>
> I don't quite understand why the patching failed.
>
> I am relatively a newbie and following this :
> http://hbase.apache.org/book/submitting.patches.html
>
> Help appreciated.
>
> thanks very much
> Sujee
>
>
> ----output from :
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> patching file
> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
> Hunk #1 FAILED at 466.
> 1 out of 1 hunk FAILED -- saving rejects to file
> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
> PATCH APPLICATION FAILED
>
>
> -1 overall. Here are the results of testing the latest attachment
>
> http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvaluation_HBASE_5198.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified
> tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output:
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> This message is automatically generated.
> -------
>
> http://sujee.net
>

Re: need a little help with a patch submission

Harsh J 2012-03-12, 19:45

Hi,

Use {{git diff --no-prefix}} when generating your patches, as the QA
bot assumes its an SVN patch and thats how you can make it compatible.

But please file a JIRA to add such a note to the book where it
recommends "git diff".
(With a --no-prefix doc patch if you please ;))

On Tue, Mar 13, 2012 at 1:09 AM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
>
> I don't quite understand why the patching failed.
>
> I am relatively a newbie and following this :
> http://hbase.apache.org/book/submitting.patches.html
>
> Help appreciated.
>
> thanks very much
> Sujee
>
>
> ----output from :
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> patching file b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
> Hunk #1 FAILED at 466.
> 1 out of 1 hunk FAILED -- saving rejects to file
> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
> PATCH APPLICATION FAILED
>
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvaluation_HBASE_5198.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output:
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> This message is automatically generated.
> -------
>
> http://sujee.net

--
Harsh J

Re: need a little help with a patch submission

Doug Meil 2012-03-12, 19:47

I'll update the book with that...
On 3/12/12 3:45 PM, "Harsh J" <[EMAIL PROTECTED]> wrote:

>Hi,
>
>Use {{git diff --no-prefix}} when generating your patches, as the QA
>bot assumes its an SVN patch and thats how you can make it compatible.
>
>But please file a JIRA to add such a note to the book where it
>recommends "git diff".
>(With a --no-prefix doc patch if you please ;))
>
>On Tue, Mar 13, 2012 at 1:09 AM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:
>>
>>https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=1322663
>>5&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#c
>>omment-13226635
>>
>> I don't quite understand why the patching failed.
>>
>> I am relatively a newbie and following this :
>> http://hbase.apache.org/book/submitting.patches.html
>>
>> Help appreciated.
>>
>> thanks very much
>> Sujee
>>
>>
>> ----output from :
>> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>>
>> patching file
>>b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
>> Hunk #1 FAILED at 466.
>> 1 out of 1 hunk FAILED -- saving rejects to file
>> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
>> PATCH APPLICATION FAILED
>>
>>
>> -1 overall. Here are the results of testing the latest attachment
>>
>>http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvalu
>>ation_HBASE_5198.patch
>> against trunk revision .
>>
>> +1 @author. The patch does not contain any @author tags.
>>
>> +1 tests included. The patch appears to include 3 new or modified
>>tests.
>>
>> -1 patch. The patch command could not apply the patch.
>>
>> Console output:
>> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>>
>> This message is automatically generated.
>> -------
>>
>> http://sujee.net
>
>
>
>--
>Harsh J
>

Re: need a little help with a patch submission

Sujee Maniyam 2012-03-12, 20:29

ok guys, thanks for the replies.

I will regenerate the patch.

Now a little process question, on submitting the revised patch:

should I delete the previous patch attachment, cancel patch, and
attach another patch?
or
should I leave the previous attachment and attach the second one?

thanks
Sujee

Re: need a little help with a patch submission

lars hofhansl 2012-03-12, 21:32

Hi Sujee,

you just attach a new file.
I name my patches like this: <jira#>-v<version#>.txt, but that is a matter of taste.(So in your case that would "5198-v2.txt")
-- Lars

________________________________
From: Sujee Maniyam <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Sent: Monday, March 12, 2012 1:29 PM
Subject: Re: need a little help with a patch submission

ok guys, thanks for the replies.

I will regenerate the patch.

Now a little process question, on submitting the revised patch:

should I delete the previous patch attachment, cancel patch, and
attach another patch?
or
should I leave the previous attachment and attach the second one?

thanks
Sujee

Re: need a little help with a patch submission

Sujee Maniyam 2012-03-13, 21:37

On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl <[EMAIL PROTECTED]> wrote:
> Hi Sujee,
>
> you just attach a new file.
> I name my patches like this: <jira#>-v<version#>.txt, but that is a matter of taste.(So in your case that would "5198-v2.txt")
> -- Lars

thanks Lars,
one more question. So no need to delete the previous patch file?
Will the build system grab the latest attachment automatically?

Re: need a little help with a patch submission

Shrijeet Paliwal 2012-03-13, 21:39

Yes it does.

On Tue, Mar 13, 2012 at 2:37 PM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:

> On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl <[EMAIL PROTECTED]>
> wrote:
> > Hi Sujee,
> >
> > you just attach a new file.
> > I name my patches like this: <jira#>-v<version#>.txt, but that is a
> matter of taste.(So in your case that would "5198-v2.txt")
> > -- Lars
>
> thanks Lars,
> one more question. So no need to delete the previous patch file?
> Will the build system grab the latest attachment automatically?
>

Re: need a little help with a patch submission

N Keywal 2012-03-13, 21:45

Hi Sujee,

If you want to (re)submit it, you don't have to delete the previous patch.
However you need to do things in this exact order:
1 - cancel patch
2 - attach new patch
3 - submit.

If you reverse 1 & 2, you patch won't be applied.

Good luck :-)

N.

On Tue, Mar 13, 2012 at 10:37 PM, Sujee Maniyam <[EMAIL PROTECTED]> wrote:

> On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl <[EMAIL PROTECTED]>
> wrote:
> > Hi Sujee,
> >
> > you just attach a new file.
> > I name my patches like this: <jira#>-v<version#>.txt, but that is a
> matter of taste.(So in your case that would "5198-v2.txt")
> > -- Lars
>
> thanks Lars,
> one more question. So no need to delete the previous patch file?
> Will the build system grab the latest attachment automatically?
>