Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-809 Sqoop2: Remove old deprecated comments from distribution pom file


+
Jarek Cecho 2013-01-03, 12:40
Copy link to this message
-
Re: Review Request: SQOOP-809 Sqoop2: Remove old deprecated comments from distribution pom file
Cheolsoo Park 2013-01-10, 15:48


> On Jan. 9, 2013, 8:46 p.m., Cheolsoo Park wrote:
> > dist/pom.xml, line 154
> > <https://reviews.apache.org/r/8807/diff/1/?file=244527#file244527line154>
> >
> >     prior packing => prior to packing.
>
> Jarek Cecho wrote:
>     Hi Cheolsoo,
>     we do not need to build the documentation prior making package anymore - it will be created automatically. Thus I've removed the comment out in my patch.
>    
>     Jarcec

Sounds even better. I will commit it soon.
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8807/#review15213
-----------------------------------------------------------
On Jan. 3, 2013, 12:40 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8807/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 12:40 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed comments that are no longer valid.
>
>
> This addresses bug SQOOP-809.
>     https://issues.apache.org/jira/browse/SQOOP-809
>
>
> Diffs
> -----
>
>   dist/pom.xml e05359078a490c74102439f597b23209e6245b55
>
> Diff: https://reviews.apache.org/r/8807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>