Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1699. Make the rename of the meta file platform neutral


+
Hari Shreedharan 2012-11-16, 19:26
+
Roshan Naik 2012-11-16, 19:48
+
Hari Shreedharan 2012-11-16, 20:08
+
Mike Percy 2012-11-16, 20:45
+
Hari Shreedharan 2012-11-16, 21:22
+
Hari Shreedharan 2012-11-19, 04:42
+
Hari Shreedharan 2012-11-19, 04:53
+
Brock Noland 2012-11-19, 18:54
+
Hari Shreedharan 2012-11-19, 18:56
+
Hari Shreedharan 2012-11-19, 19:41
+
Brock Noland 2012-11-19, 19:47
Copy link to this message
-
Re: Review Request: FLUME-1699. Make the rename of the meta file platform neutral
Hari Shreedharan 2012-11-19, 19:56

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8087/
-----------------------------------------------------------

(Updated Nov. 19, 2012, 7:56 p.m.)
Review request for Flume and Brock Noland.
Description
-------

If atomic rename fails, rename the current meta file to old, rename tmp to meta and then delete old.
This addresses bug FLUME-1699.
    https://issues.apache.org/jira/browse/FLUME-1699
Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 82e14b0
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java f768d23
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 6b0eeb3
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java 4b69698

Diff: https://reviews.apache.org/r/8087/diff/
Testing
-------

All unit tests pass
Thanks,

Hari Shreedharan

+
Brock Noland 2012-11-19, 20:26