Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive >> mail # dev >> Review Request 16921: HIVE-6208 user-defined aggregate functions cannot be used as windowing function


+
Jason Dere 2014-01-15, 21:58
Copy link to this message
-
Re: Review Request 16921: HIVE-6208 user-defined aggregate functions cannot be used as windowing function

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16921/#review31999
-----------------------------------------------------------

Ship it!
Ship It!

- Harish Butani
On Jan. 15, 2014, 9:58 p.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16921/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 9:58 p.m.)
>
>
> Review request for hive and Harish Butani.
>
>
> Bugs: HIVE-6208
>     https://issues.apache.org/jira/browse/HIVE-6208
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> - All UDAFs are also added to window function list when registered to function registry
> - Avoid NPE when invalid function name used as window function
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 96a78fc
>   ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java f011258
>   ql/src/test/queries/clientnegative/windowing_invalid_udaf.q PRE-CREATION
>   ql/src/test/queries/clientpositive/windowing_udaf2.q PRE-CREATION
>   ql/src/test/results/clientnegative/windowing_invalid_udaf.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/windowing_udaf2.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16921/diff/
>
>
> Testing
> -------
>
> Added positive/negative test
>
>
> Thanks,
>
> Jason Dere
>
>