Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill >> mail # dev >> Review Request: DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan


+
Ben Becker 2013-06-10, 21:17
Copy link to this message
-
Re: Review Request: DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11783/#review21671
-----------------------------------------------------------

sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java
<https://reviews.apache.org/r/11783/#comment44790>

    I don't think you should use the built-in java asserts, as it won't throw the correct test exception that junit is looking for. You should use the Junit's asserts
- Timothy Chen
On June 10, 2013, 9:17 p.m., Ben Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11783/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 9:17 p.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Description
> -------
>
> Looking for validation of builder apprach.
>  - Includes LogicalPlanBuilder and PlanPropertiesBuilder attached to JIRA-45; rebased to latest execwork.
>  - Includes ScanBuilder and StoreBuilder as well.
>
> Note: One of the original builders also had a 'toBuilder()' method.  Is that something we should add for all builders?
>
>
> Diffs
> -----
>
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/PlanProperties.java c532e18
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/LogicalPlan.java a2f2499
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/LogicalPlanBuilder.java PRE-CREATION
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/PlanProperties.java PRE-CREATION
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/Scan.java c8d396b
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/ScanBuilder.java PRE-CREATION
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/Store.java 0569b8a
>   sandbox/prototype/common/src/main/java/org/apache/drill/common/logical/data/StoreBuilder.java PRE-CREATION
>   sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/LogicalPlanBuilderTest.java PRE-CREATION
>   sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java PRE-CREATION
>   sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/StoreBuilderTest.java PRE-CREATION
>   sandbox/prototype/common/src/test/resources/storage_engine_plan.json efde80d
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/PhysicalPlan.java 84bfc87
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/record/vector/NullableValueVector.java 692ab87
>
> Diff: https://reviews.apache.org/r/11783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Becker
>
>

+
Ben Becker 2013-06-10, 21:53
+
Jacques Nadeau 2013-06-11, 18:48