Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Re: Review Request 18372: Hive UDFs in Drill


Copy link to this message
-
Re: Review Request 18372: Hive UDFs in Drill
Jacques Nadeau 2014-03-01, 17:21

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18372/#review35288

common/src/main/java/org/apache/drill/common/expression/fn/CastFunctionDefs.java
<https://reviews.apache.org/r/18372/#comment65738>

    You should caps to name static variables

common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java
<https://reviews.apache.org/r/18372/#comment65740>

    Let's discuss.  Aggregate checking is important.

exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java
<https://reviews.apache.org/r/18372/#comment65741>

    rather than using a string delimiter, let's use an array of strings.
- Jacques Nadeau
On Feb. 28, 2014, 9:35 p.m., Venki Korukanti wrote: