Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 21410: Return JSON string while selecting complex types


Copy link to this message
-
Review Request 21410: Return JSON string while selecting complex types

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21410/

Review request for drill.
Bugs: DRILL-718
    https://issues.apache.org/jira/browse/DRILL-718
Repository: drill-git
Description

The getObject() method of complex vectors now use subclassed versions of HashMap and ArrayList, the subclass overrides the toString() method which converts the HashMap, List to a JSON string.
Diffs

  exec/java-exec/src/main/codegen/includes/vv_imports.ftl 71404d3
  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 537c7fd
  exec/java-exec/src/main/codegen/templates/TypeHelper.java 4755e92
  exec/java-exec/src/main/java/org/apache/drill/exec/util/JsonStringArrayList.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/util/JsonStringHashMap.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/util/TextSerializer.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java 91c0be5
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java 93930b5
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java 2492cc8
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 761bc79
  exec/java-exec/src/test/java/org/apache/drill/exec/store/json/JsonRecordReader2Test.java 1372219

Diff: https://reviews.apache.org/r/21410/diff/
Testing

Added test to TestJsonRecordReader2
Thanks,

Mehant Baid