Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Re: Review Request 21371: Patch for DRILL-705


Copy link to this message
-
Re: Review Request 21371: Patch for DRILL-705

It's only needed since Optiq converts a Sum to $Sum0, and I needed for the output type to be Optional (Nullable), so that the If Expression can both be optional types.
I believe Optiq does it since it wants Sum0 to return 0 in no values case which we do already, but needed that function signature so Drill can understand. Any suggestions for alternatives how to address this?

Within is actually the PARTITION by expressions, so PARTITION BY X with translate into Within [ NamedExpression("X") ]

And what will the results looks like? For SUM it's just the same value for each row right?
I'm a bit fuzzy what the Window function standards are, and have been referring to Optiq's Parser Test to see what valid options there are.

I'm utilizing the AbstractSingleRecordBatch loop to do the right handling, as I found out I'm not doing much different handling than what the default does.
If the downstream calls incoming it simply calls doWork again here.
I've modified the interface so doWork can send different IterOutcome to downstream, where before it just sends OK all the time.

I believe what you said is true, let me modify it so it can output multiple ones.
For the latter case the best way is to do add Optimizer rule to merge them then?
- Timothy
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21371/#review43130
On May 13, 2014, 9:01 p.m., Timothy Chen wrote: