Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 19723: DRILL-452: Conversion functions for external data types


Copy link to this message
-
Re: Review Request 19723: DRILL-452: Conversion functions for external data types

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/#review40483

common/src/main/java/org/apache/drill/common/types/Types.java
<https://reviews.apache.org/r/19723/#comment73512>

    I think it would be better to return a MinorType, and then let the caller choose the DataMode, rather than returning a REQUIRED type here.

exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java
<https://reviews.apache.org/r/19723/#comment73508>

    Would it be very difficult to generate these functions instead of writing them by hand?
- Steven Phillips
On April 3, 2014, 2:09 p.m., Aditya Kishore wrote: