Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 19665: DRILL-450 : insert exchange operators to support distributed query execution.


Copy link to this message
-
Re: Review Request 19665: DRILL-450 : insert exchange operators to support distributed query execution.
Aman Sinha 2014-03-31, 15:48

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19665/#review39036
Sending some initial comments based on a first pass. May send more later.  One high-level thought:  we have the batch iterator validator ... we could  enhance it to check for redundant traits.  For example, if the validator sees that a child is already producing something distributed by column a1 and the parent is a HashExchange that is doing the same, then it should throw an error.  Similarly for Sort traits.  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java
<https://reviews.apache.org/r/19665/#comment71426>

    spellings: 'stream' instead of 'steam', 'creation' instead of 'creating'

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
<https://reviews.apache.org/r/19665/#comment71427>

    Does this log message need an argument ? (there's {} braces in the message).

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
<https://reviews.apache.org/r/19665/#comment71428>

    Should cleanup() be called before killIncoming rather than after ?

exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PhysicalPlanCreator.java
<https://reviews.apache.org/r/19665/#comment71433>

    Change 'created' to 'creation'.

exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrule.java
<https://reviews.apache.org/r/19665/#comment71434>

    It wasn't clear to me if max parallelization width is > 1 then why it should be RANDOM_DISTRIBUTED..could it not be HASH_DISTRIBUTED ? Or is that we don't know how exactly it is distributed..
- Aman Sinha
On March 30, 2014, 9:35 p.m., Jinfeng Ni wrote: