Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 18501: DRILL-386 Implement External Sort operator


Copy link to this message
-
Re: Review Request 18501: DRILL-386 Implement External Sort operator
Steven Phillips 2014-03-06, 12:05

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18501/

(Updated March 6, 2014, 12:05 p.m.)
Review request for drill.
Changes

addressed code review comments and rebased off latest master.
Repository: drill-git
Description

See https://issues.apache.org/jira/browse/DRILL-386
Diffs (updated)

  distribution/src/resources/runbit 85daf87
  exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 2d81299
  exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 051c62d
  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 4677374
  exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 5cd83af
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java bcc113f
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java 93f1992
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/ExternalSort.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 89edaf3
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/RecordBatchData.java e01bf37
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java 5fd12c0
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortRecordBatchBuilder.java d8bbc6a
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortTemplate.java f9835f6
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java 78326ca
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/trace/TraceRecordBatch.java c9a73f9
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/BatchGroup.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatchCreator.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueCopier.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueCopierTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueSelector.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueSelectorTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorter.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/record/ExpandableHyperContainer.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java 6e764a8
  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 1be5392
  exec/java-exec/src/main/java/org/apache/drill/exec/util/BatchPrinter.java aa68752
  exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 4f8cd33
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/ValueVector.java a3d3a8a
  exec/java-exec/src/main/resources/drill-module.conf 4dd08c1
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/GeneratorFunctions.java b79ccd0
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java PRE-CREATION
  exec/java-exec/src/test/resources/drill-external-sort.conf PRE-CREATION
  exec/java-exec/src/test/resources/sort/one_key_sort.json baabcb3
  exec/java-exec/src/test/resources/xsort/one_key_sort_descending.json PRE-CREATION

Diff: https://reviews.apache.org/r/18501/diff/
Testing
Thanks,

Steven Phillips