Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 18841: Patch for DRILL-88


Copy link to this message
-
Re: Review Request 18841: Patch for DRILL-88

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18841/#review36603

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
<https://reviews.apache.org/r/18841/#comment67643>

    Seems a bit odd to have a class variable but populate it every get call. I think either check null or just make it return a new list everytime as it seems to do that already

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
<https://reviews.apache.org/r/18841/#comment67644>

    return new copy?

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
<https://reviews.apache.org/r/18841/#comment67645>

    Is is possible to get columns back without ROW_KEY? In this case it won't be added.

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
<https://reviews.apache.org/r/18841/#comment67646>

    intentional to leave out the row key vector?

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
<https://reviews.apache.org/r/18841/#comment67647>

    When will this be null?

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
<https://reviews.apache.org/r/18841/#comment67649>

    Are we only supporting VarBinary type from HBase?

contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
<https://reviews.apache.org/r/18841/#comment67648>

    Remove, and don't need to clean up ResultScanner?

exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
<https://reviews.apache.org/r/18841/#comment67650>

    Is this a fix?
- Timothy Chen
On March 6, 2014, 9:24 a.m., Steven Phillips wrote: