Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 20486: New code gen implementation for Trigonometric math functions


Copy link to this message
-
Re: Review Request 20486: New code gen implementation for Trigonometric math functions
Yash Sharma 2014-04-23, 09:18

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/

(Updated April 23, 2014, 9:18 a.m.)
Review request for drill, Jinfeng Ni and Mehant Baid.
Changes

Patch cleanup and formatting
Repository: drill-git
Description

New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.

These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs (updated)

  exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
  exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
  exec/java-exec/src/test/resources/functions/testNewMathFunctions.json PRE-CREATION
  exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION

Diff: https://reviews.apache.org/r/20486/diff/
Testing

Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc

ACTUAL_RESULTS EXPECTED_RESULTS
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,

Yash Sharma