Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 18347: Implement hash aggregation operator and a hash table (for Drill-335) and new templates for aggregate functions (Drill-318)


Copy link to this message
-
Re: Review Request 18347: Implement hash aggregation operator and a hash table (for Drill-335) and new templates for aggregate functions (Drill-318)

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18347/#review37149

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
<https://reviews.apache.org/r/18347/#comment68534>

    Won't the cloned containers share the vectors with the original if you use this method? Maybe I'm missing something, but this looks like it will cause corruption.

exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java
<https://reviews.apache.org/r/18347/#comment68536>

    After calling clone, the new container and incoming container will have references to the same vectors? Is the desired behavior to create new vectors of the same type?
- Steven Phillips
On March 6, 2014, 2:10 a.m., Aman Sinha wrote: