Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 19591: Patch for DRILL-442


Copy link to this message
-
Re: Review Request 19591: Patch for DRILL-442

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19591/

(Updated March 25, 2014, 12:11 a.m.)
Review request for drill.
Bugs: DRILL-442
    https://issues.apache.org/jira/browse/DRILL-442
Repository: drill-git
Description (updated)

DRILL-442 Implement text format plugin

allow reading a particular value in a repeated vector

fix test caused by change that allows selecting element of repeated record

set def recordCount for explain query

fix bug loading repeated vectors

storage plugin/format plugin changes. store storage plugin configuration in distributed cache.

add repeated vector allocators

add support for for reading compressed files.

Address Tim's code review comments

cleanup
Diffs (updated)

  common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g be2a3f26c1ab6f634d9d651dd77bc0d0d2b92fd8
  common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java 20b4d66a8c1ce6264f0ada7300bdda1686d40da6
  common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java e6403592696838ad3a2675045546bd857f3f4941
  common/src/main/java/org/apache/drill/common/util/DataInputInputStream.java c4c22826ab2c084f29598d382c47d24fd7a7ed31
  distribution/src/resources/storage-engines.json 8b22858c0f88e0e567fe89fa0564cb28ec1435aa
  exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 4677374a77846d439db53d0b9a55a4e53f75f2b2
  exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 5cd83afecc24a1fba3d5b566d565d460235e5e63
  exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java bcc113f0f0cec9355a95236ae72c8bf465ac55f2
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java 875e8b6f9eff9f1cec2601680ad9334c63044760
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/JacksonDrillSerializable.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java 38de688e95cd5e266156e8df7a80a004ea6cf318
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java ff7ab02f9d38420013b23aa85bad5ea6ddf38ec2
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 8dfba7679e5015e6c18eb996d1cab062929d1920
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java f764d32fc1d6ab3e203040252ef5810dae74f3e0
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/ValueVectorReadExpression.java 5e251a1c7b6061274e60e398244e167f04dbb966
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Alternator.java bdd227c95fd6cffdebe32a82749d76e1c4d523cb
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java 949b5f734f80f4746778834c35e67bec3efcc3fe
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/RemovingRecordBatch.java 78326cad4da979b1c2e9791972215754d60cfc2d
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 7398d782a9ae4e534ea80c83df9ab26b8021edc3
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/StorageEngines.java d2980406847f863de42fc5c9202d9381300fecfb
  exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 6400c75758b77aa631842b2538e7d35f81cd919d
  exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ce153414a0e5d666aee113e486e694c9a44776cf
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java 50678a6fd61e16464f16e68875200727ad7184e9
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemConfig.java 455c4b280ba080f05995b8ea0e73fadd571d0d67
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 3762c1a2689aa17de23fccb30789b683f6033466
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatCreator.java 7ce8c50546f137d02d70f0a9cb310edb0223cd97
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/NamedFormatPluginConfig.java 6b98ea223fc9bb327b5b4be60fba1cff5c472a8a
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java d7949c376ef93bcb2ad4366f18f73ba209a6dcd0
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java a7f556e90aa35d62c391e629796261640b36ea40
  exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasySubScan.java 72d1fe6ed0dbdc137aba05fabae038b9ee6ba1a8
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java 82bf3bfc86f2fad6fcbe7bfc44452e1632b75cce
  exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatConfig.java 33eb68a2f0c220e753d2ccc488dbf5114b179a1e
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java f76e59a6ec3efd897e083ea4a755971a4fedcf13
  exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java eaa4f174eeb50e17ab0a2fb1300ad68a0506d270
  exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java 432c1d76432b38aad13725dee9cd750903c73bbe
  exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/CompleteFileWork.java 30b08f6fa0d23f881224a6ba4c93c83ea662f389
  exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/util/VectorUtil.java a35bb5feb90cda421140c6bb972758c80c32c8fb
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedVariableWidthVector.java 556c9a9a1910fbcc0294b96e7a5658cbaeabe87f
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/allocator/RepeatedVariableEstimatedAllocator.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/vector/allocator/RepeatedVectorAllocator.java PRE-CREATION
  exec/java-exec/src/