Aditya Kishore 2014-03-27, 14:16
Aditya Kishore 2014-03-28, 10:32
-Re: Review Request 19723: DRILL-452: Conversion functions for external data types
This is an automatically generated e-mail. To reply, visit:
In all places like this, you need to wrap the buffer with SwappedByteBuf as Drill buffers are always little endian but Unpooled returns a big endian. We'll have a better fix for this soon.
Can you add to the test a check that convert_from and convert_to by themselves works as expected. I think that right now (with the buffer endianness issue above), that they will not.
- Jacques Nadeau
On March 28, 2014, 10:31 a.m., Aditya Kishore wrote:
Aditya Kishore 2014-03-29, 07:01
Aditya Kishore 2014-03-29, 07:03
Aditya Kishore 2014-04-03, 14:10
Steven Phillips 2014-04-16, 00:27
Aditya Kishore 2014-04-22, 21:44
Aditya Kishore 2014-04-22, 21:43