Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 19723: DRILL-452: Conversion functions for external data types


Copy link to this message
-
Re: Review Request 19723: DRILL-452: Conversion functions for external data types
Jacques Nadeau 2014-03-28, 16:26

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/#review38899

exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/ConvertToBigIntBE.java
<https://reviews.apache.org/r/19723/#comment71221>

    In all places like this, you need to wrap the buffer with SwappedByteBuf as Drill buffers are always little endian but Unpooled returns a big endian.  We'll have a better fix for this soon.  

exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
<https://reviews.apache.org/r/19723/#comment71222>

    Can you add to the test a check that convert_from and convert_to by themselves works as expected.  I think that right now (with the buffer endianness issue above), that they will not.
- Jacques Nadeau
On March 28, 2014, 10:31 a.m., Aditya Kishore wrote: