Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java


Copy link to this message
-
Re: Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8305/#review13940
-----------------------------------------------------------
Hi Venkat,
thank you very much for your time and effort working on this JIRA. I do have just couple of high level suggestions:
client/src/main/java/org/apache/sqoop/client/core/ClientError.java
<https://reviews.apache.org/r/8305/#comment29746>

    Sqoop is currently using common schema for exception all over the place and the named constants are quite important. I would suggest to leave the exception handling "as it is" for now and file additional JIRA for translating them.

client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java
<https://reviews.apache.org/r/8305/#comment29747>

    What about using static call MessageFormat.format here and on all other places? That way we would skip explicit object and explicit array creation.
- Jarek Cecho
On Dec. 1, 2012, 4:49 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8305/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2012, 4:49 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> I have moved localizable strings to the client resources (those that are descriptions, messages in general etc).  Also consolidated constants to one place and removed repetitive occurrences.  
>
> 4 more files in utils need to be updated, but wanted to get this reviewed and take that after this
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/ClientError.java fd3b97d
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 47c0547
>   client/src/main/java/org/apache/sqoop/client/request/Request.java 1720507
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java 847a6ad
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 21c41aa
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java b0e8d90
>   client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java 2453543
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 734276d
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 0b685bf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java bb09bf3
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java ee2a1cf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java acc8e21
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java 03499d8
>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java 20c8090
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 3764306
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java daf1ff4
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java bd74253
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4e49288
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java a34c48c
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 8dcf976
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java ee8c63d
>   client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java 039e28b
>   client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java 9e8c607
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java 9ae693e
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java 200b3ee
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java b2d05f4
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 39a2b31