-Re: Proposal: consolidate execwork and master
Tanujit Ghosh 2013-07-20, 03:41
I downloaded the source after the latest merge into master and tried
compiling and getting the following error during mvn build
[ERROR] Failed to execute goal
(default-compile) on project java-exec: Compilation failure: Compilation
class Workspace is public, should be declared in a file named Workspace.java
duplicate class: org.apache.drill.exec.expr.annotations.Workspace
[ERROR] -> [Help 1]
On Sat, Jul 20, 2013 at 7:33 AM, Jacques Nadeau <[EMAIL PROTECTED]> wrote:
> Based on this feedback, I've now merged execwork and master so are the
> same. I also tagged the pre-merge changeset for later reference.
> Please rebase your changes against master and continue your future
> development and patch work there.
> For those that haven't tried it out yet, check out FishEye, nice
> ability to review the source tree.
> On Tue, Jul 16, 2013 at 1:34 AM, Michael Hausenblas
> <[EMAIL PROTECTED]> wrote:
> > +1 from my side as well, but we really need to document this clearly and
> nicely on the Wiki, in big red <blink> letters ;)
> > Cheers,
> > Michael
> > --
> > Michael Hausenblas
> > Ireland, Europe
> > http://mhausenblas.info/
> > On 16 Jul 2013, at 09:17, Srihari Srinivasan <[EMAIL PROTECTED]>
> >> +1...this will be very useful for fresh starters!
> >> On Tue, Jul 16, 2013 at 1:58 AM, Jacques Nadeau <[EMAIL PROTECTED]>
> >>> The vision of the execwork branch was to maintain a development branch
> >>> and then merge to master once we were happy with the quality and unit
> >>> test completeness of the execwork stuff. However, it now appears that
> >>> everyone is working in the execwork branch. Additionally, I've also
> >>> had a number of offhand comments from those less familiar with the
> >>> project who assume that a lack of commits on master means the project
> >>> is less active than it is. As such, I propose that we merge the
> >>> execwork branch back into master and continue to do our work there.
> >>> With the lastest push of Ben's patches for ValueVectors and the merge
> >>> of DRILL-140 into execwork, execwork includes all the changes in
> >>> master and all tests pass.
> >>> Jacques