Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Re: Review Request: Allow hdfs idle callback to clean up closed bucket writers


Copy link to this message
-
Re: Review Request: Allow hdfs idle callback to clean up closed bucket writers
Juhani Connolly 2013-01-22, 04:34

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9052/
-----------------------------------------------------------

(Updated Jan. 22, 2013, 4:34 a.m.)
Review request for Flume.
Summary (updated)
-----------------

Allow hdfs idle callback to clean up closed bucket writers
Description
-------

Stops close() from removing the idle callback and skips close in the idle callback if the writer is already closed.
Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 3f31ef2

Diff: https://reviews.apache.org/r/9052/diff/
Testing
-------

Tests pass. Since sfWriters is protected it is hard to verify the changed behavior in unit tests. I however verified the behaviour in the java debugger.
Thanks,

Juhani Connolly

+
Roshan Naik 2013-01-22, 04:55
+
Juhani Connolly 2013-01-22, 05:05